Optimize merkle #90
Open
Optimize merkle #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stylus #90 +/- ##
==========================================
+ Coverage 54.78% 55.11% +0.32%
==========================================
Files 247 247
Lines 37558 37604 +46
==========================================
+ Hits 20576 20725 +149
+ Misses 14614 14506 -108
- Partials 2368 2373 +5 |
tsahee
commented
Jul 21, 2023
| empty_hash: Bytes32, | ||
| min_depth: usize, | ||
| ) -> Merkle { | ||
| pub fn get_empty(ty: MerkleType, layer: usize) -> Bytes32 { |
There was a problem hiding this comment.
note: moving from each markle storing it's own empty_layers vec to all sharing the same one didn't save any time on generating proofs. I still like it - but might be worth considering if added complexity is worth it.
tsahee
commented
Jul 24, 2023
tsahee
commented
Jul 27, 2023
| MerkleType::Empty => panic!("attempted to fetch empty-layer value from empty merkle"), | ||
| MerkleType::Memory => Memory::MEMORY_LAYERS, | ||
| MerkleType::Opcode => 2, | ||
| MerkleType::ArgumentData => 2, |
There was a problem hiding this comment.
Note: not sure if it's necessary. I gave opcode and argument data min_depth 2 to avoid short functions producing a "root" that's not hashed at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split func to a mostly-empty additional-data merkle and condensed opcode merkle.
Optimize mostly-empty merkles.
Note: the last commit, caching and reusing empty hashes across merkles, doesn't seem to save time.
contract upgrade required: OffchainLabs/stylus-contracts#6