Add stylus programSize and programMemoryFootprint precompiles #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stylus #120 +/- ##
==========================================
- Coverage 56.47% 56.44% -0.04%
==========================================
Files 276 276
Lines 42665 42684 +19
==========================================
- Hits 24094 24091 -3
- Misses 16111 16118 +7
- Partials 2460 2475 +15 |
rachel-bousfield
suggested changes
Sep 6, 2023
system_tests/program_test.go
Outdated
Comment on lines
92
to
96
| programMemoryFootprint, err := arbWasm.ProgramMemoryFootprint(nil, programAddress) | ||
| Require(t, err) | ||
| if programMemoryFootprint != 1 { | ||
| Fatal(t, "unexpected memory footprint", programMemoryFootprint) | ||
| } |
There was a problem hiding this comment.
Lets move this to the memory test, which has an example that's known to be 120 pages :)
system_tests/program_test.go
Outdated
Comment on lines
87
to
91
| programSize, err := arbWasm.ProgramSize(nil, programAddress) | ||
| Require(t, err) | ||
| if programSize < 5000 || programSize > 20000 { | ||
| Fatal(t, "unexpected size", programSize) | ||
| } |
There was a problem hiding this comment.
I think we know the exact size and could check against it
arbos/programs/programs.go
Outdated
Comment on lines
336
to
346
| func (p Programs) CodehashSize(codeHash common.Hash) (uint32, error) { | ||
| program, err := p.deserializeProgram(codeHash) | ||
| // wasmSize represents the number of half kb units, return as bytes | ||
| return uint32(program.wasmSize) * 512, err | ||
| } | ||
|
|
||
| func (p Programs) CodehashMemoryFootprint(codeHash common.Hash) (uint16, error) { | ||
| program, err := p.deserializeProgram(codeHash) | ||
| return program.footprint, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's name these ProgramSize and ProgramMemoryFootprint, but still have them take codehashes
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires