Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanan/create split #57

Merged
merged 22 commits into from
Sep 11, 2024
Merged

Hanan/create split #57

merged 22 commits into from
Sep 11, 2024

Conversation

HananINouman
Copy link
Collaborator

No description provided.

@HananINouman HananINouman marked this pull request as ready for review August 26, 2024 14:46
@HananINouman HananINouman requested a review from a team as a code owner August 26, 2024 14:46
src/ajv.ts Outdated Show resolved Hide resolved
src/constants.ts Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
test/sdk-package-test/utils.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@LukeHackett12 LukeHackett12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this looks good! some small comments, once it is merged/released might take another pass at the documentation after playing around with it

* @param {RewardsSplitPayload} rewardsSplitPayload - Data needed to deploy owr and splitter.
* @returns {Promise<ClusterValidator>} owr address as withdrawal address and splitter as fee recipient
*/
// add the example reference
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but can add it once i add the example in obol-sdk-examples

src/utils.ts Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
47.4% Duplication on New Code (required ≤ 30%)

See analysis details on SonarCloud

@HananINouman HananINouman merged commit e5935d9 into main Sep 11, 2024
1 of 2 checks passed
@HananINouman HananINouman deleted the Hanan/create-split branch September 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants