app/eth2wrap: fallback beacon nodes #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a way to provide eth2wrap with two classes of beacon nodes addresses: standard and fallback beacon nodes. When one of the multi BN calls fails, eth2wrap wrappers will try to get an available fallback BN from a list and re-do the call on that. If no fallback BNs is specified, return the original error. If the fallback BN call fails, return fallback error instead. This PR firstly introduces concepts and code, will introduce CLI parameters and initialization code later.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3342 +/- ##
==========================================
- Coverage 58.77% 58.27% -0.51%
==========================================
Files 210 211 +1
Lines 30213 30699 +486
==========================================
+ Hits 17758 17889 +131
- Misses 10564 10915 +351
- Partials 1891 1895 +4 ☔ View full report in Codecov by Sentry. |
pinebit
reviewed
Nov 19, 2024
pinebit
approved these changes
Nov 19, 2024
KaloyanTanev
reviewed
Jan 7, 2025
KaloyanTanev
approved these changes
Jan 7, 2025
gsora
added
the
merge when ready
DiogoSantoss
pushed a commit
that referenced
this pull request
Jan 7, 2025
Implement a way to provide eth2wrap with two classes of beacon nodes addresses: standard and fallback beacon nodes. When one of the multi BN calls fails, eth2wrap wrappers will try to get an available fallback BN from a list and re-do the call on that. If no fallback BNs is specified, return the original error. If the fallback BN call fails, return fallback error instead. This PR firstly introduces concepts and code, will introduce CLI parameters and initialization code later. category: feature ticket: #3328
DiogoSantoss
pushed a commit
that referenced
this pull request
Jan 14, 2025
Implement a way to provide eth2wrap with two classes of beacon nodes addresses: standard and fallback beacon nodes. When one of the multi BN calls fails, eth2wrap wrappers will try to get an available fallback BN from a list and re-do the call on that. If no fallback BNs is specified, return the original error. If the fallback BN call fails, return fallback error instead. This PR firstly introduces concepts and code, will introduce CLI parameters and initialization code later. category: feature ticket: #3328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a way to provide eth2wrap with two classes of beacon nodes addresses: standard and fallback beacon nodes.
When one of the multi BN calls fails, eth2wrap wrappers will try to get an available fallback BN from a list and re-do the call on that.
If no fallback BNs is specified, return the original error.
If the fallback BN call fails, return fallback error instead.
This PR firstly introduces concepts and code, will introduce CLI parameters and initialization code later.
category: feature
ticket: #3328