v.stream.network: Fix tostream name, fix for v8 #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenzeslaus
commented
Jul 27, 2023
•
wenzeslaus
commented
- Fixes use of custom tostream which was ignored.
- Updates interfacing with numpy for Python 3.
- Updates v.to.db use for v8 where columns are created automatically (saves >10 lines here).
- Simplifies code and removes old code and comments.
- Renames variables and comply more with Flake8 and Pylint.
- Adds tests.
- Explains input more.
- Adds reference.
- Fixes use of custom tostream which was ignored. - Updates interfacing with numpy for Python 3. - Updates v.to.db use for v8 where columns are created automatically (saves >10 lines here). - Simplify code and remove old code and comments. - Rename variables and comply more with Flake8 and Pylint. - Explain input more. - Add reference.
awickert
approved these changes
Jul 29, 2023
And here: Thanks for bearing with the few-days delay -- I know that writing good code and then having it sit can be annoying. I just got back to Potsdam. Many thanks as always, for all your work on GRASS! |
|
You are welcome and thanks for the reviews and merges. Much appreciated! |
cwhite911
pushed a commit
to cwhite911/grass-addons
that referenced
this pull request
Sep 19, 2023
- Fixes use of custom tostream which was ignored. - Updates interfacing with numpy for Python 3. - Updates v.to.db use for v8 where columns are created automatically (saves >10 lines here). - Simplify code and remove old code and comments. - Rename variables and comply more with Flake8 and Pylint. - Explain input more. - Add reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.