ALPHA 3. ETF. Add installation and check of java11 as sudo to ensure its installation #412
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ETF install file for OSGeoLive 17 to work with new OS and Java version
Fixed changing java version assigning manually java version to be used by jetty
added sudo flag on line 85 and 90 (check for java11 in system and install it as sudo user)
update and add installation and check of java11 as sudo to ensure installation
jenriquesoriano
changed the title
jenriquesoriano
changed the title
|
All the scripts are supposed to run with sudo |
…ader about running as sudo
Changed user to SUDO_USER (whoami if it fails) and add info in the header about running as sudo
Remove explicit sudo execution, since: - install script will run as sudo - a check for sudo user is included
Remove explicit sudo execution, since: - install script will run as sudo - a check for sudo user is included
|
Thanks, PR modified accordingly |
|
I can still see conflicts with master |
- Rollback to keep existing sudo in master branch - Included comment to explain to execute it as sudo - Included sudo in java installation
|
Dear @kalxas , Apologies for the misunderstanding. We have updated the PR to include sudo only in the Java installation step (just in case), and we have also added instructions in the header to install it using sudo. With these changes, the installation will now work both for the root user and for any regular user. Please note that the ETF reads the .etf folder from the user executing the system at startup, so ensuring that any user can handle this is also crucial. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on alpha 3 we have noted that java11 will not be installed succesfully if not run as sudo, so we have added sudo in the installation file on the lines where java11 is checked and then installed (line 85 and 90)