Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ServerConfiguration & GDS Server for ECC #2817

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Oct 27, 2024

Proposed changes

Extend ConfigurationNode Manager to support multiple Application Certificates & be able to regenerate the private Key of ECC Certificates. Add Trust List Support for User Certificates & Https Certificates.

Extend the GDS to be able to be configured with ECC Certificate Types and generate / sign ECC Certificates.
In a second step the GDS will need to be extended to allow multiple Certificate Types specified per CertificateGroup and handle multiple CAs per Certificate Group (one per Certificate Type). Also the CertificateTypes need to be reflected in the Namespace.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

…ficates. Trust List Support for User Certificates & Https Certificates
@romanett romanett requested a review from mregen October 27, 2024 10:39
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 83.10811% with 25 lines in your changes missing coverage. Please review.

Project coverage is 55.34%. Comparing base (b2d715d) to head (434bcf6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...a.Server/Configuration/ConfigurationNodeManager.cs 76.00% 8 Missing and 4 partials ⚠️
...aries/Opc.Ua.Gds.Server.Common/CertificateGroup.cs 78.84% 5 Missing and 6 partials ⚠️
...raries/Opc.Ua.Configuration/ApplicationInstance.cs 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2817      +/-   ##
==========================================
- Coverage   55.70%   55.34%   -0.36%     
==========================================
  Files         352      352              
  Lines       67332    67408      +76     
  Branches    13806    13818      +12     
==========================================
- Hits        37506    37307     -199     
- Misses      25792    26014     +222     
- Partials     4034     4087      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett requested a review from mrsuciu November 1, 2024 10:43
@romanett romanett changed the title Extend ServerConfiguration for ECC Extend ServerConfiguration & GDS for ECC Nov 3, 2024
@romanett romanett changed the title Extend ServerConfiguration & GDS for ECC Extend ServerConfiguration & GDS Server for ECC Nov 3, 2024
@romanett romanett self-assigned this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gds Server (Client) FinishRequest fails for ECC Server Certificate
1 participant