Added a minimal rogue client detection mechanism at the transport level #3494
Annotations
1 error and 10 warnings
|
Test
Process completed with exit code 1.
|
|
Build:
Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs#L416
The behavior of 'Convert.ToUInt32(string)' could vary based on the current user's locale settings. Replace this call in 'TcpTransportListener.UpdateChannelLastActiveTime(string)' with a call to 'Convert.ToUInt32(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L648
The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Stack/Opc.Ua.Core/Stack/Configuration/SecurityConfigurationManager.cs#L95
Avoid inexact read with 'System.IO.FileStream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
|
|
Build:
Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs#L539
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
|
|
Build:
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs#L1103
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
|
|
Build:
Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs#L586
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
|
|
Build:
Libraries/Opc.Ua.Client/Session/TraceableSession.cs#L1303
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
|
Build:
Applications/Quickstarts.Servers/MemoryBuffer/MemoryBufferNodeManager.cs#L237
The behavior of 'Convert.ToUInt32(string)' could vary based on the current user's locale settings. Replace this call in 'MemoryBufferNodeManager.GetManagerHandle(ISystemContext, NodeId, IDictionary<NodeId, NodeState>)' with a call to 'Convert.ToUInt32(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Applications/Quickstarts.Servers/Alarms/AlarmNodeManager.cs#L146
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'AlarmNodeManager.CreateAddressSpace(IDictionary<NodeId, IList<IReference>>)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Applications/Quickstarts.Servers/Alarms/AlarmHolders/DiscreteHolder.cs#L88
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'DiscreteHolder.SetValue([string])' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
Loading