libckteec: fix memory allocation leakage on template serialization

Fix memory allocation leakage with a call to release_serial_object() to release obj2 before serialize_indirect_attribute() returns. Link: #387 Fixes: e88c264 ("libckteec: helper function to serialize a attribute template") Signed-off-by: Hoyong Jin <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
OP-TEE · Sep 24, 2024 · 49e646d · 49e646d
1 parent 0293dd9
commit 49e646d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/libckteec/src/serialize_ck.c b/libckteec/src/serialize_ck.c
@@ -95,17 +95,19 @@ static CK_RV serialize_indirect_attribute(struct serializer *obj,
 	 */
 	rv = serialize_32b(obj, attribute->type);
 	if (rv)
-		return rv;
+		goto out;
 
 	rv = serialize_32b(obj, obj2.size);
 	if (rv)
-		return rv;
+		goto out;
 
 	rv = serialize_buffer(obj, obj2.buffer, obj2.size);
 	if (rv)
-		return rv;
+		goto out;
 
 	obj->item_count++;
+out:
+	release_serial_object(&obj2);
 
 	return rv;
 }