Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor fill_species_configs #152

Merged
merged 7 commits into from
Feb 15, 2024
Merged

refactor fill_species_configs #152

merged 7 commits into from
Feb 15, 2024

Conversation

chrisroadmap
Copy link
Collaborator

@chrisroadmap chrisroadmap commented Feb 15, 2024

Pull request

Please confirm that this pull request has done the following:

  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

DONE

Fixes #151

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c09bee8) 95.08% compared to head (83a3177) 94.92%.

❗ Current head 83a3177 differs from pull request most recent head 3a6b5b0. Consider uploading reports for the commit 3a6b5b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   95.08%   94.92%   -0.16%     
==========================================
  Files          19       20       +1     
  Lines         732      709      -23     
  Branches      105      106       +1     
==========================================
- Hits          696      673      -23     
  Misses         16       16              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisroadmap chrisroadmap merged commit 94dc9a2 into master Feb 15, 2024
4 checks passed
@chrisroadmap chrisroadmap deleted the fix-sc branch February 15, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fill_species_configs is erroring when aci type not defined
1 participant