Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cornerstone-dicom-sr): Freehand SR hydration support #3996

Merged
merged 18 commits into from
Apr 5, 2024

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Mar 18, 2024

Context

The Freehand ROI annotation SR hydration was not working for both SR and Cornerstone viewports

Changes & Results

  • Freehand ROI SRs are created and hydrated properly in OHIF

Testing

  • Link to cornerstone3d adapters and tools packages locally and create/hydrate Freehand ROI SRs

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

N/A

Public Documentation Updates

N/A

Tested Environment

  • "OS: 14.4.1 (23E224)
  • "Node version: 16.14
  • "Browser: Chrome Version 123.0.6312.59 (Official Build) (x86_64)

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 284baaf
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/660fc683a1adc9000869cc4d
😎 Deploy Preview https://deploy-preview-3996--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 284baaf
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/660fc6836ccd580008de64ae
😎 Deploy Preview https://deploy-preview-3996--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.37%. Comparing base (8a335bd) to head (6d01fc5).
Report is 287 commits behind head on master.

❗ Current head 6d01fc5 differs from pull request most recent head 284baaf. Consider uploading reports for the commit 284baaf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3996      +/-   ##
==========================================
- Coverage   46.23%   44.37%   -1.87%     
==========================================
  Files          78       80       +2     
  Lines        1276     1334      +58     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      589      +41     
- Partials      138      153      +15     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5892d...284baaf. Read the comment docs.

@igoroctaviano igoroctaviano changed the title [WIP] fix(cornerstone-dicom-sr): Freehand SR loading fix(cornerstone-dicom-sr): Freehand SR loading Mar 18, 2024
@igoroctaviano igoroctaviano requested a review from sedghi March 27, 2024 20:30
Copy link

cypress bot commented Mar 27, 2024

Passing run #3794 ↗︎

0 43 0 0 Flakiness 0

Details:

update CS3D
Project: Viewers Commit: 284baafe25
Status: Passed Duration: 06:01 💡
Started: Apr 5, 2024 9:55 AM Ended: Apr 5, 2024 10:01 AM

Review all test suite changes for PR #3996 ↗︎

@igoroctaviano igoroctaviano changed the title fix(cornerstone-dicom-sr): Freehand SR loading fix(cornerstone-dicom-sr): Freehand SR hydration support Mar 28, 2024
@IbrahimCSAE IbrahimCSAE self-requested a review April 4, 2024 13:03
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the CS3D changes and it works fine

Peek 2024-04-04 09-18

@sedghi
Copy link
Member

sedghi commented Apr 5, 2024

@IbrahimCSAE can you rebase this in Monday? thanks

@IbrahimCSAE IbrahimCSAE merged commit 5645ac1 into master Apr 5, 2024
7 checks passed
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants