-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cornerstone-dicom-sr): Freehand SR hydration support #3996
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3996 +/- ##
==========================================
- Coverage 46.23% 44.37% -1.87%
==========================================
Files 78 80 +2
Lines 1276 1334 +58
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 589 +41
- Partials 138 153 +15 see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Passing run #3794 ↗︎
Details:
Review all test suite changes for PR #3996 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IbrahimCSAE can you rebase this in Monday? thanks |
Co-authored-by: Ibrahim <[email protected]> Co-authored-by: IbrahimCSAE <[email protected]>
Context
The Freehand ROI annotation SR hydration was not working for both SR and Cornerstone viewports
Changes & Results
Testing
PR
semantic-release format and guidelines.
Code
N/A
Public Documentation Updates
N/A
Tested Environment