Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DICOM SR Support for additional/common annotations #1215 #2469

Closed
wants to merge 18 commits into from

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Jul 8, 2021

Roadmap

  • Editable Freehand (waiting for dmcjs PR)
  • Editable Rectangle (waiting for dmcjs PR)
  • Read-only SCOORD3D bounding box (score)
  • Read-only SCOORD3D points

@igoroctaviano igoroctaviano self-assigned this Jul 8, 2021
@igoroctaviano igoroctaviano changed the base branch from master to feat/v2-main July 8, 2021 12:41
@netlify
Copy link

netlify bot commented Jul 21, 2021

✔️ Deploy Preview for ohif-platform-viewer ready!

🔨 Explore the source changes: 5efe39f

🔍 Inspect the deploy log: https://app.netlify.com/sites/ohif-platform-viewer/deploys/616830cd58ba8e00087b5729

😎 Browse the preview: https://deploy-preview-2469--ohif-platform-viewer.netlify.app

@netlify
Copy link

netlify bot commented Jul 21, 2021

✔️ Deploy Preview for ohif-platform-docs canceled.

🔨 Explore the source changes: 5efe39f

🔍 Inspect the deploy log: https://app.netlify.com/sites/ohif-platform-docs/deploys/616830cd98284b0007127000

igoroctaviano and others added 8 commits August 5, 2021 09:56
* Rebased to have just the static view changes

* Changes based on the PR

* Couple more changes for the PR

* Removed an extraneous log

* Fix the study worklist display when returning to the page

* Added some documentation on the static wado data source setup, and a
bounds check change on the Queue test which was failing

* PR updates - change the undefined study description to '' and remove the aws deploy

* Fixed the e2e tests to actually pass/fail correctly on actual results
@igoroctaviano igoroctaviano changed the base branch from feat/v2-main to v3-stable October 14, 2021 13:07
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v3-stable@ef06b76). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             v3-stable    #2469   +/-   ##
============================================
  Coverage             ?   24.86%           
============================================
  Files                ?      121           
  Lines                ?     2904           
  Branches             ?      563           
============================================
  Hits                 ?      722           
  Misses               ?     1888           
  Partials             ?      294           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef06b76...5efe39f. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 14, 2021



Test summary

24 0 0 0


Run details

Project Viewers
Status Passed
Commit 5efe39f
Started Oct 14, 2021 1:51 PM
Ended Oct 14, 2021 1:53 PM
Duration 02:21 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jul 10, 2022
@sedghi sedghi removed the Stale 🥖 label Jan 11, 2023
@sedghi sedghi changed the base branch from v3-stable to master June 19, 2023 13:37
@sedghi
Copy link
Member

sedghi commented Jun 19, 2023

What is the plan for this? Do we still want this? @igoroctaviano Do you have plan to work on this?

@fedorov
Copy link
Member

fedorov commented Jun 19, 2023

We have some of this implemented in v2 and will definitely need it in v3 for IDC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants