Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial github workflow #3

Open
wants to merge 1 commit into
base: master-with-README
Choose a base branch
from

Conversation

lefessan
Copy link
Member

No description provided.

@GitMensch
Copy link
Collaborator

As there are no other users and the commit is not too old, I'd suggest to place all those changes into the previous one and force-push the branch afterwards (so one instead of 2-N commits for the workflow).

Note: It would be nice to have both the PDF and the HTML versions generated.
Another note: you likely don't need libtool libdb5.3-dev libxml2-dev libcjson-dev bison flex help2man gettext in this workflow.

@lefessan lefessan force-pushed the z-2024-01-13-simple-github-workflow branch from b567ebf to fcb48bc Compare January 13, 2024 09:46
@lefessan
Copy link
Member Author

Yes, I will squash everything in the previous commit. I was forced to push that first commit, otherwise Github would not start testing it :-(

@lefessan
Copy link
Member Author

Note that I get the same error locally on my computer: makeinfo segfaults on gnucobpg, but not on other files. This is a known behavior ?

@lefessan lefessan force-pushed the z-2024-01-13-simple-github-workflow branch 2 times, most recently from b8ad229 to 71f14fa Compare January 13, 2024 10:37
@lefessan
Copy link
Member Author

@vbcoen Wondering if you want to review the changes to .texi files in this PR ?

Copy link
Collaborator

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR currently mixes changes that are:

  • for the mirror only (should be here, actually stashed to the previous commit)
  • are reasonable tex internal changes -> should get into upstream directly
  • have some changes at least I don't understand

Note that "cobc - The GnuCOBOL Compiler - Runtime options" doesn't make any sense - either that refers to dialect or compile options or this is not related to cobc in the first place

guide/gnucobpg.texi Outdated Show resolved Hide resolved
guide/cbrese.tex Outdated Show resolved Hide resolved
guide/7.texi Show resolved Hide resolved
@GitMensch
Copy link
Collaborator

GitMensch commented Jan 13, 2024

Note that I get the same error locally on my computer: makeinfo segfaults on gnucobpg, but not on other files. This is a known behavior ?

No. Also "some time ago" it definitely did work.
Do you still have the segfault after the changes?

If there is a segfault in makeinfo, then there's definitely a bug there; please send reproducible steps with a link to the files needed to the appropriate bug tracker.
Ideally you can download its debug package and start the process under gdb, to include a backtrace when that happens to the bug report.

@lefessan lefessan force-pushed the z-2024-01-13-simple-github-workflow branch 2 times, most recently from 0e8deba to 4bd5ba0 Compare January 13, 2024 13:55
@vbcoen
Copy link
Contributor

vbcoen commented Jan 13, 2024

I cannot see where these changes are stored and available to preview, at least with the changes to the indexing and menu etc.

Are they available ?

@lefessan
Copy link
Member Author

lefessan commented Jan 13, 2024

I cannot see where these changes are stored and available to preview, at least with the changes to the indexing and menu etc.

Are they available ?

I moved the changes to the indexing/menu in another PR, this one just fixes html generation on the Github Actions.

For any PR, if you want to see the generated files, you can go in the corresponding checks -> Ubuntu Workflow -> Summay -> Artefacts, there should be one zip for all pdfs, and another one for html pages.

@lefessan
Copy link
Member Author

Note that "cobc - The GnuCOBOL Compiler - Runtime options" doesn't make any sense - either that refers to dialect or compile options or this is not related to cobc in the first place

I just fixed the reference. That's the original title of the corresponding section. I understand it as "there are the options that the compiler accepts at runtime", by opposition with the options that can be used to build the compiler ("compile time option").

@GitMensch
Copy link
Collaborator

GitMensch commented Jan 13, 2024

Please adjust this - the only "real" compile time options are which libraries are used (the others don't make much difference for the use of cobc).

* Rename @anchoridx{Data} to @anchoridx{DateTypes} in section 13 (duplicate
  with the same index in section 7)
* Remove @validatemenus not available after version 6.8 of texinfo
* Rename section "cobc - The GnuCOBOL Compiler - Runtime options" to
  "cobc - The GnuCOBOL Compiler"
* Add @Iftex around menu of section 7.8, as it makes makeinfo segfault and
  is not useful for HTML
* Small additional fixes for info generation to work
@lefessan lefessan force-pushed the z-2024-01-13-simple-github-workflow branch from 9ce2e6f to d9b6fe3 Compare January 13, 2024 21:49
@@ -1506,7 +1506,7 @@ When the @code{LOCALE} keyword is not specified, the returning value is negative
@comment ** 8.1.70B NUMVAL-C **
@comment *********************************************************************
@page
@newsubsection{8.1.70B,NUMVAL-C-V2}
@newsubsection{8.1.70B,NUMVAL-C-2}
Copy link
Collaborator

@GitMensch GitMensch Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea what this "B" is? Looks like two times the identical thing, no?
@vbcoen Did I miss something here? [if it is to be removed, then this should be done after the technical change which removes the renumbering problem, @lefessan could commit both the technical and "minor tweaks" change if you agree.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it looks like it documents the same function twice, with a different explanation. Maybe somebody started improving the description by copying it temporarily, but never finished the job ?

lefessan pushed a commit that referenced this pull request Feb 3, 2024
git-svn-id: svn+ssh://svn.code.sf.net/p/gnucobol/code/external-doc@5211 ed166372-6744-4ac0-a67f-bb1ae9efa102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants