-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] web_ir_actions_act_view_reload #2272
Conversation
Note, previous attempt at #2240 |
950b573
to
31fcecb
Compare
28f21bd
to
ceca3bd
Compare
/ocabot migration web_ir_actions_act_view_reload |
The migration issue (#2053) has been updated to reference the current pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0.
If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.
[UPD] Update web_ir_actions_act_view_reload.pot [UPD] README.rst
Ref: OCA#1462 (comment) [UPD] Update web_ir_actions_act_view_reload.pot [UPD] README.rst
Includes some manual fixes to silent ESLint warnings. [UPD] README.rst [UPD] README.rst
Unresolved reference self and module odoo.api has no attribute multi [UPD] README.rst [UPD] Brainbean Apps => CorporateHub [UPD] README.rst
[UPD] Update web_ir_actions_act_view_reload.pot [UPD] README.rst
Thanks Pedro. I see that the fork branch should be named |
Don't worry about the branch name in this case, as such name is only a transient one that is not transferred to any place once the pull request is merged. It's better to not use |
Thanks @pedrobaeza, for sure there will be some more PRs to come! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something does not work:
I followed this steps:
- Access runboat
- Create a server action on any model with the code
action={'type': 'ir.actions.act_view_reload'}
- Create the Contextual Action
- Refresh
- Access the model and press the button
- The following error is raised:
Error: The ActionManager service can't handle actions of type ir.actions.act_view_reload
at doAction (http://oca-web-15-0-pr2272-3d7bde7f5331.runboat.odoo-community.org/web/assets/debug/web.assets_backend.js:25001:23) (/web/static/src/webclient/actions/action_service.js:1138)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested @etobella use case and tested if is added the action by code.
It seems to be working fine
Thanks!
Thanks @CarlosRoca13! Ping @etobella, it looks like the merge is blocked because of a change request. Could you please take a look? |
@etobella I followed your scenario and I did not encounter this problem. Running the action correctly triggered the method that this module registers for the action type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!! Now it works perfectly
😄
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 879d66d. Thanks a lot for contributing to OCA. ❤️ |
Fortunately, Odoo 15.0 is still using the old-style controllers/renderers, so this wasn't too difficult once we can access the legacy
widget
.The 16.0 migration for this module might be interesting!