Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] web_ir_actions_act_view_reload #2272

Merged
merged 10 commits into from
Oct 4, 2022
Merged

Conversation

ryanc-me
Copy link

@ryanc-me ryanc-me commented Aug 9, 2022

Fortunately, Odoo 15.0 is still using the old-style controllers/renderers, so this wasn't too difficult once we can access the legacy widget.

The 16.0 migration for this module might be interesting!

@ryanc-me
Copy link
Author

ryanc-me commented Aug 9, 2022

Note, previous attempt at #2240

@ryanc-me ryanc-me force-pushed the 15.0 branch 2 times, most recently from 950b573 to 31fcecb Compare August 9, 2022 04:15
@ryanc-me ryanc-me mentioned this pull request Aug 9, 2022
47 tasks
@ryanc-me ryanc-me force-pushed the 15.0 branch 2 times, most recently from 28f21bd to ceca3bd Compare August 9, 2022 04:20
@ryanc-me ryanc-me marked this pull request as ready for review August 9, 2022 04:25
@pedrobaeza
Copy link
Member

/ocabot migration web_ir_actions_act_view_reload

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 9, 2022
@OCA-git-bot
Copy link
Contributor

The migration issue (#2053) has been updated to reference the current pull request.
however, a previous pull request was referenced : #2240.
Perhaps you should check that there is no duplicate work.
CC : @manuelcalerosolis

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

pnajman-modoolar and others added 8 commits August 10, 2022 09:08
[UPD] Update web_ir_actions_act_view_reload.pot

[UPD] README.rst
Ref: OCA#1462 (comment)

[UPD] Update web_ir_actions_act_view_reload.pot

[UPD] README.rst
Includes some manual fixes to silent ESLint warnings.

[UPD] README.rst

[UPD] README.rst
Unresolved reference self and module odoo.api has no attribute multi

[UPD] README.rst

[UPD] Brainbean Apps => CorporateHub

[UPD] README.rst
[UPD] Update web_ir_actions_act_view_reload.pot

[UPD] README.rst
@ryanc-me ryanc-me marked this pull request as ready for review August 9, 2022 21:29
@ryanc-me
Copy link
Author

ryanc-me commented Aug 9, 2022

Thanks Pedro.

I see that the fork branch should be named 15.0-mig-$MODULE - I can't change that without creating a new PR. Will the current state work for you?

@pedrobaeza
Copy link
Member

Don't worry about the branch name in this case, as such name is only a transient one that is not transferred to any place once the pull request is merged. It's better to not use 15.0 one, as you can have several pull requests for the same branch, though, but for following ones ( that I hope to be a lot 😄 )

@ryanc-me
Copy link
Author

Thanks @pedrobaeza, for sure there will be some more PRs to come!

@pedrobaeza pedrobaeza dismissed their stale review August 15, 2022 09:26

Formal requirements are done

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something does not work:

I followed this steps:

  • Access runboat
  • Create a server action on any model with the code action={'type': 'ir.actions.act_view_reload'}
  • Create the Contextual Action
  • Refresh
  • Access the model and press the button
  • The following error is raised:
Error: The ActionManager service can't handle actions of type ir.actions.act_view_reload
    at doAction (http://oca-web-15-0-pr2272-3d7bde7f5331.runboat.odoo-community.org/web/assets/debug/web.assets_backend.js:25001:23) (/web/static/src/webclient/actions/action_service.js:1138)

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested @etobella use case and tested if is added the action by code.

It seems to be working fine

Thanks!

@ryanc-me
Copy link
Author

ryanc-me commented Oct 4, 2022

Thanks @CarlosRoca13!

Ping @etobella, it looks like the merge is blocked because of a change request. Could you please take a look?

@StefanRijnhart
Copy link
Member

@etobella I followed your scenario and I did not encounter this problem. Running the action correctly triggered the method that this module registers for the action type.

image

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!! Now it works perfectly
😄

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2272-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6c9500c into OCA:15.0 Oct 4, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 879d66d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.