Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cancelled state in job runner #533

Merged
merged 1 commit into from
May 3, 2023
Merged

Handle cancelled state in job runner #533

merged 1 commit into from
May 3, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented May 2, 2023

Towards #531

From the point of view of the job runner, a cancelled job is the same as a done job: it frees the channel.

@sbidoul sbidoul added this to the 14.0 milestone May 2, 2023
@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul mentioned this pull request May 2, 2023
Open
@sbidoul
Copy link
Member Author

sbidoul commented May 3, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-533-by-sbidoul-bump-patch, awaiting test results.

@sbidoul sbidoul mentioned this pull request May 3, 2023
Merged
@OCA-git-bot OCA-git-bot merged commit fa92fbf into OCA:14.0 May 3, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7eedfe4. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 14.0-cancelled-state-sbi branch May 3, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@guewen guewen guewen approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sbidoul @OCA-git-bot @guewen @hparfr