[14.0][ADD] product_pricelist_overcharge_by_amount #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-RB
force-pushed
the
14.0-add-product_pricelist_overcharge_by_amount
branch
2 times, most recently
from
ac9bf06
to
f2351fe
Compare
Christian-RB
force-pushed
the
14.0-add-product_pricelist_overcharge_by_amount
branch
from
f2351fe
to
9032427
Compare
|
|
||
|
|
||
| class ProductPricelistOverchargeItem(models.Model): | ||
| _name = "product.pricelist.overcharge.item" |
There was a problem hiding this comment.
@Christian-RB Please split one model per file. Thanks
There was a problem hiding this comment.
@rousseldenis Thanks for the review and apologies for the delayed response. AFAIK if the model is used as a One2many field in the main model, it was acceptable to include it in the same file. Has this approach changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module enables adding or subtracting amounts from a final pricelist item, applying rules directly to the price.