[17.0][ADD] product_identification. #1728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murtaza-OSI
force-pushed
the
17.0-add-product_identification
branch
from
39850cb
to
4e0c1e1
Compare
Murtaza-OSI
force-pushed
the
17.0-add-product_identification
branch
from
4e0c1e1
to
ffb2423
Compare
legalsylvain
requested changes
Sep 24, 2024
|
|
||
|
|
||
| class ProductIdCategory(models.Model): | ||
| _name = "product.product.id_category" |
There was a problem hiding this comment.
except an historical error in odoo, there is no "_" in model name.
maybe "product.identification.category" is enought. don't you think ? (and product.identification instead of product.product.id_number)
| _inherit = "product.template" | ||
|
|
||
| id_numbers = fields.One2many( | ||
| "product.product.id_number", "product_id", string="Identification Numbers" |
There was a problem hiding this comment.
it doesn't looks consistent.
id_numbers = fields.One2many()
in product.template
but in the other model, it is in product.product
product_id = fields.Many2one("product.product", string="Product")
I think you should choose between product and template.
| class ProductTemplate(models.Model): | ||
| _inherit = "product.template" | ||
|
|
||
| id_numbers = fields.One2many( |
There was a problem hiding this comment.
Suggested change
| id_numbers = fields.One2many( | |
| identification_ids = fields.One2many( |
| date_issued = fields.Date() | ||
| expiry_date = fields.Date() | ||
| place_of_issue = fields.Char(string="Place of Issue") | ||
| product_id = fields.Many2one("product.product", string="Product") |
There was a problem hiding this comment.
Suggested change
| product_id = fields.Many2one("product.product", string="Product") | |
| product_id = fields.Many2one("product.product", string="Product", required=True) |
I guess it doesn't make sense to have an inentification without product. Or did i missed something ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.