[14.0] [MIG] account_statement_import_coda #130

marielejeune · 2022-02-01T16:38:59Z

No description provided.

The module is a rewrite of l10n_be_coda using the pycoda parser.

Use the Structured Communication as name else use the communication if it's provided else use '/'. If the line is a details line use the communication from the related globalisation as name. The module now depends of l10n_be_coda since the first one is automatically installed when installing l10n_be. The menuitem 'Import Coda File' from l10n_be_coda is however removed to avoid confusion and force the use of the current module

…ote of statement line with the same transaction_ref

The declaration prevents the install of the module if the dependency is not met

…ty constraint with the demo data of l10n_be_coda.

this makes the test more robust (the previous version did not work in presence of account_constraints, and could not be run twice in a row on the same database)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-belgium-12.0/l10n-belgium-12.0-account_bank_statement_import_coda Translate-URL: https://translation.odoo-community.org/projects/l10n-belgium-12-0/l10n-belgium-12-0-account_bank_statement_import_coda/

[MIG] account_bank_statement_import_coda: Migration to 13.0 [MIG] account_bank_statement_import_coda: Migration to 13.0 [MIG] account_bank_statement_import_coda: Migration to 13.0 [UPD] Update account_bank_statement_import_coda.pot [UPD] README.rst

…ement_import_coda

marielejeune · 2022-02-02T07:39:36Z

Migration of account_bank_statement_import_coda from v13 to v14. Changed the name of the module to follow what was done for account_statement_import.

houssine78

LGTM

OCA-git-bot · 2022-02-14T10:33:11Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

houssine78 · 2022-02-14T10:46:20Z

@robinkeunen I think we have a PR ready to me merged here

gva-acsone

LGTM

sbidoul · 2022-02-14T14:26:33Z

/ocabot merge patch

OCA-git-bot · 2022-02-14T14:26:48Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-130-by-sbidoul-bump-patch, awaiting test results.

OCA-git-bot · 2022-02-14T14:32:50Z

Congratulations, your PR was merged at 37202ef. Thanks a lot for contributing to OCA. ❤️

alexis-via · 2022-11-07T15:33:43Z

account_statement_import_coda/wizard/account_statement_import_coda.py

+        if line.transaction_amount_sign == AmountSign.DEBIT:
+            amount = -amount
+        return {
+            "name": self.get_st_line_name(line, globalisation_dict),


Now that account.bank.statement.line inherit from account.move, you're not supposed to force the "name" in this dict! Otherwise, the move will not have the "name" set by this code instead of having the "name" set by the journal like all the other moves. You should just set "payment_ref".

Hi @alexis-via. I agree with you. A PR was opened several months ago with this fix, but wasn't approved yet. See #139

Btw, a second PR with another fix is here, could you also have a look please? #140

lmignon and others added 30 commits February 1, 2022 11:54

Add module account_bank_statement_import_coda

748a6e9

The module is a rewrite of l10n_be_coda using the pycoda parser.

[PYLINT] Fix W1401(anomalous-backslash-in-string)

8414657

[ADD] add README.rst file

6523e0d

[IMP] remove dependency on l10n_be_coda

b128b5c

[IMP] The communication of information records is now stored in the n…

a481f86

…ote of statement line with the same transaction_ref

[IMP] use the new_balance_date as statement date

dd50775

[FIX] use year 2012

a40ace5

[IMP] Add journal code as prefix for statement name

7e81d8d

[IMP] rename method

521cdb3

[FIX] Declare external python dependency

c3f3db8

The declaration prevents the install of the module if the dependency is not met

[FIX] Changes the account number in the demo data to honour the unici…

18586bc

…ty constraint with the demo data of l10n_be_coda.

[IMP] Define a valid IBAN account number in demo data

89bf9b4

normalize version number

ba86dcb

[IMP] coda import: do not rely on demo data

53771dc

this makes the test more robust (the previous version did not work in presence of account_constraints, and could not be run twice in a row on the same database)

[FIX] coda import: _complete_statement has been renamed, apparently

cf4b5f4

[IMP] coda import: some linting

4e7a42c

[IMP] coda import: update README, short headers

98078f2

OCA Transbot updated translations from Transifex

f5adc85

[FIX] remove en.po files that have been erroneously added by tx_pull

bb11989

OCA Transbot updated translations from Transifex

5b549b6

[MIG] bank_statement_import_coda: migrate from 8 to 10

556ef18

[11.0][MIG] bank_statement_import_coda

83a604c

[ADD] add CODA in the import statement wizard form

bafe7c4

Clean setup

288b147

[UPD] README.rst

cb0b99e

[UPD] Update account_bank_statement_import_coda.pot

5cf2b38

[MIG] change version

8bcc373

[IMP] need to add the import format file

fe44b77

[IMP] set a more elaborated uniq_import_id

5c6d9be

oca-transbot and others added 7 commits February 1, 2022 11:54

[IMP] account_bank_statement_import_coda: black, isort, prettier

978049d

account_bank_statement_import_coda 13.0.1.0.1

aaaf0b6

[IMP] account_bank_statement_import_coda: black, isort, prettier

78a0478

[CHG] module_name: account_bank_statement_import_coda -> account_stat…

d920a9d

…ement_import_coda

[MIG] account_statement_import_coda: Migration to 14.0

13171f9

marielejeune marked this pull request as draft February 1, 2022 16:39

marielejeune marked this pull request as ready for review February 1, 2022 16:44

marielejeune changed the title ~~14.0 mig account bank statement import coda~~ [14.0] [MIG] account_statement_import_coda Feb 1, 2022

[IMP] account_statement_import_coda: fix communication label

1a65ddf

sbidoul approved these changes Feb 8, 2022

View reviewed changes

sbidoul requested review from qgroulard and gva-acsone February 10, 2022 08:05

houssine78 approved these changes Feb 14, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 14, 2022

gva-acsone approved these changes Feb 14, 2022

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 14, 2022

OCA-git-bot merged commit b63bae4 into OCA:14.0 Feb 14, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 14, 2022

sbidoul deleted the 14.0-mig-account_bank_statement_import_coda branch February 14, 2022 14:41

alexis-via reviewed Nov 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] [MIG] account_statement_import_coda #130

[14.0] [MIG] account_statement_import_coda #130

marielejeune commented Feb 1, 2022

marielejeune commented Feb 2, 2022 •

edited

Loading

houssine78 left a comment

OCA-git-bot commented Feb 14, 2022

houssine78 commented Feb 14, 2022

gva-acsone left a comment

sbidoul commented Feb 14, 2022

OCA-git-bot commented Feb 14, 2022

OCA-git-bot commented Feb 14, 2022

alexis-via Nov 7, 2022

marielejeune Nov 17, 2022 •

edited

Loading

[14.0] [MIG] account_statement_import_coda #130

[14.0] [MIG] account_statement_import_coda #130

Conversation

marielejeune commented Feb 1, 2022

marielejeune commented Feb 2, 2022 • edited Loading

houssine78 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 14, 2022

houssine78 commented Feb 14, 2022

gva-acsone left a comment

Choose a reason for hiding this comment

sbidoul commented Feb 14, 2022

OCA-git-bot commented Feb 14, 2022

OCA-git-bot commented Feb 14, 2022

alexis-via Nov 7, 2022

Choose a reason for hiding this comment

marielejeune Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

marielejeune commented Feb 2, 2022 •

edited

Loading

marielejeune Nov 17, 2022 •

edited

Loading