Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] website_event_contact #406

Merged
merged 3 commits into from
Oct 29, 2024
Merged

[16.0] [MIG] website_event_contact #406

merged 3 commits into from
Oct 29, 2024

Conversation

Shide
Copy link

@Shide Shide commented Oct 29, 2024 •
edited
Loading

@Shide Shide force-pushed the 16.0-mig-website_event_contact branch from 5181308 to e3fd699 Compare October 29, 2024 11:15
@rafaelbn rafaelbn added this to the 16.0 milestone Oct 29, 2024
rafaelbn
rafaelbn approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot 👍🏼

/ocabot migration website_event_contact

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 29, 2024
Open
16 tasks
Gelojr
Gelojr approved these changes Oct 29, 2024
View reviewed changes
Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job @Shide

loida-vm
loida-vm approved these changes Oct 29, 2024
View reviewed changes
Copy link

@loida-vm loida-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test successful.
However I would add to the Readme that this configuration is for the registration page view.
"Go to the website backend > Register > And then edit that page"

👍🏼

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-406-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 64548e4 into OCA:16.0 Oct 29, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 57e473c. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-mig-website_event_contact branch October 29, 2024 14:16
@rafaelbn
Copy link
Member

Hello @sbidoul ,

Do you know how can we add (maintainers) the label "hacktoberfest" to the repo we maintain?

Let me know if possible please. Thank you!

Best

@Shide
Copy link
Author

Shide commented Oct 31, 2024 •
edited
Loading

Hey @sbidoul, could you add "hacktoberfest" label (or topic) to this repo?
Like this repo https://github.com/OCA/stock-logistics-workflow

https://github.com/topics/hacktoberfest

@sbidoul
Copy link
Member

sbidoul commented Oct 31, 2024

I would assume that PSC can add labels to a repo?

If not, maybe open an issue on https://github.com/oca/repo-maintainer-conf to discuss that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gelojr Gelojr Gelojr approved these changes

@loida-vm loida-vm loida-vm approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Shide @rafaelbn @OCA-git-bot @sbidoul @loida-vm @Gelojr @mikevhe18