[16.0][ADD] event_sale_seat_reserve #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imlopes
force-pushed
the
16.0-new-event_sale_seat_reserve
branch
from
4a3a521
to
29897f2
Compare
imlopes
force-pushed
the
16.0-new-event_sale_seat_reserve
branch
3 times, most recently
from
10db0da
to
c2c53f7
Compare
ivantodorovich
approved these changes
Jul 31, 2024
imlopes
force-pushed
the
16.0-new-event_sale_seat_reserve
branch
2 times, most recently
from
19336eb
to
83ddd9a
Compare
imlopes
force-pushed
the
16.0-new-event_sale_seat_reserve
branch
from
83ddd9a
to
8bc9aea
Compare
ivantodorovich
approved these changes
Aug 1, 2024
Comment on lines
+31
to
+35
| if config["test_enable"] and not self.env.context.get( | ||
| "test_event_seat_reserve" | ||
| ): | ||
| _logger.info("Test mode is enabled, skipping the reservation of the seats") | ||
| return res |
There was a problem hiding this comment.
If you need to skip tests then your code is not properly testable. This is a big quality warning IMO
There was a problem hiding this comment.
I'm skipping test because in some standard tests, we're checking if a registration is on draft state.
But, with this module, a registration with a sale will be automatically on "reserved" state.
There was a problem hiding this comment.
This technique is totally legit to keep compatibility with old/other flows for the rest of the modules. It's not for this module. It's for not making the other tests (even standard ones) not to fail. I don't think there's other option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #394