[16.0][ADD] website_event_online_ui module #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Thibagon tests are failing, can you have a look ? |
Thibagon
changed the title
remi-filament
suggested changes
Aug 7, 2024
There was a problem hiding this comment.
Hi @Thibagon your module do not install because of a number of issues !
See suggestions made.
| <record id="website_event_online_ui_search_inherit" model="ir.ui.view"> | ||
| <field name="name">event.website_event_oneline_ui.search</field> | ||
| <field name="model">event.event</field> | ||
| <field name="inherit_id">event.view_event_search</field> |
There was a problem hiding this comment.
Suggested change
| <field name="inherit_id">event.view_event_search</field> | |
| <field name="inherit_id" ref="event.view_event_search" /> |
| domain="[('address_id', '=', False)]" | ||
| /> | ||
| </xpath> | ||
| <xpath expr="//group[@string='Group_by']" position="inside"> |
There was a problem hiding this comment.
Suggested change
| <xpath expr="//group[@string='Group_by']" position="inside"> | |
| <xpath expr="//group" position="inside"> |
Using string is not allowed in xpath.
|
|
||
|
|
||
| <template | ||
| inherit_id="events_list" |
There was a problem hiding this comment.
Mising module
Suggested change
| inherit_id="events_list" | |
| inherit_id="website_event.events_list" |
Comment on lines
11
to
19
| <xpath expr="//main/small[@itemprop='location']" position="after"> | ||
| <div class="d-flex align-items-center"> | ||
| <i class="fa fa-map-marker me-2" title="Location" /> | ||
| <small | ||
| t-if="event.address_id" | ||
| class="o_not_editable fw-bold" | ||
| itemprop="location" | ||
| t-out="event.address_id" | ||
| t-options="{'widget': 'contact', 'fields': ['city'], 'no_marker': 'true'}" | ||
| /> | ||
| <small t-else="" class="o_not_editable fw-bold" itemprop="location"> | ||
| Online event | ||
| </small> | ||
| </div> | ||
| </xpath> | ||
| <xpath expr="//main/small[@itemprop='location']" position="attributes"> | ||
| <attributes name="invisible">1</attributes> | ||
| </xpath> |
There was a problem hiding this comment.
xpath does not exist...
Suggested change
| <xpath expr="//main/small[@itemprop='location']" position="after"> | |
| <div class="d-flex align-items-center"> | |
| <i class="fa fa-map-marker me-2" title="Location" /> | |
| <small | |
| t-if="event.address_id" | |
| class="o_not_editable fw-bold" | |
| itemprop="location" | |
| t-out="event.address_id" | |
| t-options="{'widget': 'contact', 'fields': ['city'], 'no_marker': 'true'}" | |
| /> | |
| <small t-else="" class="o_not_editable fw-bold" itemprop="location"> | |
| Online event | |
| </small> | |
| </div> | |
| </xpath> | |
| <xpath expr="//main/small[@itemprop='location']" position="attributes"> | |
| <attributes name="invisible">1</attributes> | |
| </xpath> | |
| <xpath expr="//main/div[@itemprop='location']" position="attributes"> | |
| <attribute name="t-if">event.address_id</attribute> | |
| </xpath> | |
| <xpath expr="//main/div[@itemprop='location']" position="after"> | |
| <div | |
| t-else="" | |
| class="o_not_editable fw-bold" | |
| itemprop="location" | |
| >Online event</div> | |
| </xpath> |
Comment on lines
4
to
5
| inherit_id="event_description_full" | ||
| ud="website_event_online_ui_page_registration" |
There was a problem hiding this comment.
Missing module and incorrect property ud
Suggested change
| inherit_id="event_description_full" | |
| ud="website_event_online_ui_page_registration" | |
| inherit_id="website_event.event_description_full" | |
| id="website_event_online_ui_page_registration" |
Comment on lines
9
to
12
| <h6 t-else=""> | ||
| <i class="fa fa-map-marker" title="Location" /> | ||
| Online event | ||
| </h6> |
There was a problem hiding this comment.
Please reuse look and feel from address :
Suggested change
| <h6 t-else=""> | |
| <i class="fa fa-map-marker" title="Location" /> | |
| Online event | |
| </h6> | |
| <div t-else="" class="o_wevent_sidebar_block"> | |
| <h6 class="o_wevent_sidebar_title">Location</h6> | |
| <h4 itemprop="location"> | |
| <i class="fa fa-map-marker" title="Location" /> | |
| Online event | |
| </h4> | |
| </div> |
remi-filament
force-pushed
the
website_online_event
branch
from
10c7127
to
d86dafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct backport of this commit
This module is an UI improvement