Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP-FIX] website_event_membership_restriction: Use variable to condition the button classes #376

Conversation

pilarvargas-tecnativa
Copy link

Use variable to condition the button classes to avoid errors in the views and also adds better readability.

cc @Tecnativa

@pedrobaeza @chienandalu please review

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-fix-website_event_membership_restriction branch from ca9f526 to b5bf3e3 Compare June 5, 2024 06:49
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-fix-website_event_membership_restriction branch 2 times, most recently from 746351a to 589aa73 Compare June 5, 2024 07:11
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-fix-website_event_membership_restriction branch from 589aa73 to 8ddcd4c Compare June 5, 2024 07:18
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 5, 2024
…tion the button classes

Use variable to condition the button classes to avoid errors in the views and also adds better readability.
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-fix-website_event_membership_restriction branch from 8ddcd4c to 235f7c8 Compare June 5, 2024 07:48
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-376-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1a68ba8 into OCA:16.0 Jun 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d425f2b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-fix-website_event_membership_restriction branch June 5, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants