[16.0][MIG] contract_sale_generation: Migration to 16.0 #955

JesusValdez96 · 2023-05-28T02:18:36Z

Replacing #914

Migration according to migration guide.
Fix tests failing due to dates and discount field not showing if user doesn't have group_discount_per_so_line

…ata (OCA#130) * [FIX+IMP] contract: Improve usability and don't fail on wrong data * Cron create invoices masked for avoiding silent errors * New constraints for assuring data consistency * UI helps for entering consistent data * Spanish translation * Remove double company_id field on form * [FIX] contract_sale_generation: Adapt tests to upstream contract

* Change the method called in the view * Complete the create_invoice method * Bump version + authoring * Correct bad call of method Small Documentation * Add super call in python test * FIX bad field names causing bad quantities in sale.order.line

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/gl/

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/de/

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/fi/

Currently translated at 100.0% (15 of 15 strings) Translation: contract-12.0/contract-12.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/pt_BR/

Currently translated at 100.0% (15 of 15 strings) Translation: contract-12.0/contract-12.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/fr/

….order.line The product UOM qty was not correctly set on the Sale Order Line During the creation of a recurring Order from a Contract, the given quantity on the Contract Line was not correctly set on the created Sale Order Line.

Use the generation_type field defined now in contract base module. Improve tests

…e line values

…r cron

…fter generation on contract level As in contract module, recompute recurring_next_date after sale generation on contract level

…l (for recurrency on contract)

Currently translated at 73.3% (11 of 15 strings) Translation: contract-14.0/contract-14.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale_generation/it/

Currently translated at 93.3% (14 of 15 strings) Translation: contract-15.0/contract-15.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract_sale_generation/it/

JesusValdez96 · 2023-05-30T02:09:25Z

@rousseldenis could you review this?

rousseldenis · 2023-05-30T06:41:04Z

/ocabot migration contract_sale_generation

OCA-git-bot · 2023-05-30T06:41:14Z

The migration issue (#880) has been updated to reference the current pull request.
however, a previous pull request was referenced : #914.
Perhaps you should check that there is no duplicate work.
CC : @vibhascs

rousseldenis

Some questions

rousseldenis · 2023-05-30T06:43:40Z

contract_sale_generation/models/contract.py

-        # Get other sale values from partner onchange
-        sale.onchange_partner_id()
+        # Get other sale values
+        sale._compute_partner_shipping_id()


Should we really call the computes ? Wouldn't the values automatically computed ?

rousseldenis · 2023-05-30T06:45:54Z

contract_sale_generation/models/contract_line.py

@@ -11,7 +11,7 @@ def _prepare_sale_line_vals(self, dates, order_id=False):
        sale_line_vals = {
            "product_id": self.product_id.id,
            "product_uom_qty": self._get_quantity_to_invoice(*dates),
-            "product_uom": self.uom_id.id,
+            "product_uom": self.product_id.uom_id.id,


Why changing this ? If we want to use a particular uom on contract line, that one should be used.

rousseldenis · 2023-05-30T06:46:35Z

contract_sale_generation/tests/test_contract_sale.py

@@ -87,7 +88,7 @@ def test_contract_count_sale_2(self):
        self.assertEqual(set(action["domain"][0][2]), set(orders.ids))

    def test_cron_recurring_create_sale(self):
-        self.contract_line.date_start = "2020-01-01"
+        self.contract_line.date_start = "2020-01-15"


Why this change ?

JesusValdez96 · 2023-06-02T02:45:41Z

Thanks @rousseldenis those changes were certainly not necessary.
I made some changes, could you review again?

moylop260 · 2023-06-05T17:40:56Z

/ocabot merge nobump

OCA-git-bot · 2023-06-05T17:41:02Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-955-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2023-06-05T17:48:02Z

Congratulations, your PR was merged at de97d8a. Thanks a lot for contributing to OCA. ❤️

angelmoya and others added 30 commits May 28, 2023 00:45

ADD contract_sale_generation module

3bd848e

[FIX] contract_sale_generation: Isolate sale generation (OCA#118)

8f5927a

Closes OCA#117

[FIX] contract_payment_auto: Fix freze wkhtmltopdf freezed

2bfc9ae

[FIX] contract_sale_generation: Useless test

06e1ec8

[FIX] contract. Optimize insertion of dates in invoice and lines.

c8aa5e3

Translated using Weblate (Galician)

b8bb683

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/gl/

Translated using Weblate (German)

3e76d91

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/de/

Translated using Weblate (Finnish)

7e8a29c

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/fi/

[WIP][12.0][MIG] contract_sale_generation

d28e7ad

Translated using Weblate (Portuguese (Brazil))

757b407

Currently translated at 100.0% (15 of 15 strings) Translation: contract-12.0/contract-12.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/pt_BR/

add display type in default values

875b5e6

Translated using Weblate (French)

34801b1

Currently translated at 100.0% (15 of 15 strings) Translation: contract-12.0/contract-12.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/fr/

[14.0][FIX] Travis

781328f

[14.0][MIG] contract_sale_generation

effb90a

[14.0][IMP] contract_sale_generation

7fd3439

Use the generation_type field defined now in contract base module. Improve tests

[IMP] contract_sale_generation: Improve view

bdb50e1

[14.0][IMP] contract_sale_generation: Transmit analytic account

1daeb13

[14.0][IMP] contract_sale_generation: Add hook method to retrieve sal…

35a06c2

…e line values

[14.0][IMP] contract_sale_generation: Align method on Odoo conventions

2a11663

[14.0][IMP] contract_sale_generation: Take into account new method fo…

87f7d27

…r cron

[14.0][IMP] contract_sale_generation: Remove deprecated domain onchange

d3b14ec

[14.0][IMP] contract_sale_generation: Split test and common

05758f0

[14.0][IMP] contract_sale_generation: Remove unused code

89774a6

Added translation using Weblate (Spanish (Argentina))

fd9c59b

[14.0][FIX] contract_sale_generation: Recompute next recurring date a…

4d5d3d8

…fter generation on contract level As in contract module, recompute recurring_next_date after sale generation on contract level

[14.0][FIX] contract_sale_generation: Add start date on contract leve…

058febd

…l (for recurrency on contract)

[14.0][IMP] contract_sale_generation: Add tests with another recurrency

2e84b92

scigghia and others added 5 commits May 28, 2023 01:03

Translated using Weblate (Italian)

42b907c

Currently translated at 73.3% (11 of 15 strings) Translation: contract-14.0/contract-14.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale_generation/it/

[MIG] contract_sale_generation: Migration to 15.0

0730d45

[FIX] contract_sale_generation: Change SavepointCase to TransactionCase

7761bc1

Translated using Weblate (Italian)

cf1dcff

Currently translated at 93.3% (14 of 15 strings) Translation: contract-15.0/contract-15.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract_sale_generation/it/

[IMP] contract_sale_generation: pre-commit stuff

6876de0

JesusValdez96 force-pushed the 16.0-mig-contract_sale_generation-jesusvaldez96 branch from 22c255f to 705a908 Compare May 30, 2023 02:03

OCA-git-bot added this to the 16.0 milestone May 30, 2023

rousseldenis added needs review migration labels May 30, 2023

OCA-git-bot mentioned this pull request May 30, 2023

Migration to version 16.0 #880

Open

13 tasks

rousseldenis mentioned this pull request May 30, 2023

16.0 mig contract sale generation #914

Closed

rousseldenis reviewed May 30, 2023

View reviewed changes

JesusValdez96 force-pushed the 16.0-mig-contract_sale_generation-jesusvaldez96 branch 2 times, most recently from a8c2c49 to 69e5520 Compare June 2, 2023 02:28

[MIG] contract_sale_generation: Migration to 16.0

d71473a

JesusValdez96 force-pushed the 16.0-mig-contract_sale_generation-jesusvaldez96 branch from 69e5520 to d71473a Compare June 2, 2023 02:36

rousseldenis approved these changes Jun 5, 2023

View reviewed changes

hugho-ad approved these changes Jun 5, 2023

View reviewed changes

OCA-git-bot added the approved label Jun 5, 2023

OCA-git-bot added the bot is merging ⏳ label Jun 5, 2023

OCA-git-bot merged commit 0eb498b into OCA:16.0 Jun 5, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] contract_sale_generation: Migration to 16.0 #955

[16.0][MIG] contract_sale_generation: Migration to 16.0 #955

JesusValdez96 commented May 28, 2023 •

edited

Loading

JesusValdez96 commented May 30, 2023

rousseldenis commented May 30, 2023

OCA-git-bot commented May 30, 2023

rousseldenis left a comment

rousseldenis May 30, 2023

rousseldenis May 30, 2023

rousseldenis May 30, 2023

JesusValdez96 commented Jun 2, 2023

moylop260 commented Jun 5, 2023

OCA-git-bot commented Jun 5, 2023

OCA-git-bot commented Jun 5, 2023

[16.0][MIG] contract_sale_generation: Migration to 16.0 #955

[16.0][MIG] contract_sale_generation: Migration to 16.0 #955

Conversation

JesusValdez96 commented May 28, 2023 • edited Loading

JesusValdez96 commented May 30, 2023

rousseldenis commented May 30, 2023

OCA-git-bot commented May 30, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis May 30, 2023

Choose a reason for hiding this comment

rousseldenis May 30, 2023

Choose a reason for hiding this comment

rousseldenis May 30, 2023

Choose a reason for hiding this comment

JesusValdez96 commented Jun 2, 2023

moylop260 commented Jun 5, 2023

OCA-git-bot commented Jun 5, 2023

OCA-git-bot commented Jun 5, 2023

JesusValdez96 commented May 28, 2023 •

edited

Loading