Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Simulation dependency on linux by making it a package #92

Closed
wants to merge 5 commits into from

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Dec 30, 2024

Changes

  • Moves the simulate binary to calypso-simulate package in the root directory
  • Moves the protobuf files to ./src/proto/ to clarify what they are to the lib.rs
  • Fix CI to pickup calypso-simulate
  • Fix Dockerfile to pickup calypso-simulate

Notes

I am unsure about whether the build.rs is being properly run when calypso-simulate is built. Its possible it is skipping all of the verification done when normally building calypso. I figure that isnt a big deal however.

Test Cases

To Do

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #82

@jr1221
Copy link
Contributor Author

jr1221 commented Dec 30, 2024

ew this is the worst thing I have ever done

@jr1221 jr1221 closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not require the socketcan library if compiling with simulation mode.
1 participant