operational round bool, simulation enum support #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrison-e
reviewed
Nov 25, 2024
There was a problem hiding this comment.
This looks good, I'm assuming you've tested that it deserializes well
harrison-e
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Looks good to me, would just want to have @tszwinglitw make sure all the sim stuff looks right.
|
Made minor simplifications in the simulation module, and merged latest canmsg changes to the new format in embedded base - should be good to merge! |
tszwinglitw
previously approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make simulation improvements.
Closes #64