Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diesel copy nonasync #263

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Diesel copy nonasync #263

wants to merge 2 commits into from

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Jan 7, 2025

Changes

  • Switch to diesel no async with a deadpool closure system
  • add a data_temp table for the use of temporary tables with an ORM
  • add a copy_many that copies into db, then inserts into data. Cannot directly insert into data as there is no conflict handling for COPY statements in postgres.
  • Remove the batching logic associated with add_many

Notes

Any other notes go here

Test Cases

  • Case A
  • Edge case
  • ...

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant