Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#260 update client for new scylla #261

Merged
merged 5 commits into from
Dec 22, 2024

Conversation

RChandler234
Copy link
Contributor

@RChandler234 RChandler234 commented Dec 21, 2024

Changes

Update client to maintain all old functionality with the new changes to Scylla:

  • Transforms list of all datatypes on the graph page to fit the node structure we were using before (I like this a lot better because any weirdness related to nodes/ how we display datatypes is localized to the graph page, so you only have to change it in one place now to change how its's displayed. This way, when/if y'all do the multiple levels of tabs on the graph page, it should be significantly easier/ only involve frontend changes on the graph page)
  • Update the DataType enum to include nodes (aka, the dataTypes are basically just topics now)

Clean up the DataType enum file, rename it, and move its file to the src/ folder, so it's not hidden away since we use it in basically all of our custom components that aren't the graph page

Also includes an update to Scylla so that the dependencies play nice on Windows (removes ability to connect to the database over TLS from Scylla, but should be no biggy)

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #260 (issue #)

@RChandler234 RChandler234 self-assigned this Dec 21, 2024
@RChandler234 RChandler234 requested a review from bracyw December 21, 2024 01:08
@RChandler234
Copy link
Contributor Author

Make sure to update the READMEs before the semester starts so that all the dev setup instructions are gtg and work on all platforms @bracyw, for Scylla and the Client, had some small issues with Scylla when testing this

@RChandler234 RChandler234 requested a review from jr1221 December 21, 2024 01:18
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. 100% works.

bracyw
bracyw previously approved these changes Dec 21, 2024
Copy link
Contributor

@bracyw bracyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RChandler234 RChandler234 merged commit 2b4a982 into develop Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Client to Work with new DataTypeName format
3 participants