-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#260 update client for new scylla #261
Conversation
Make sure to update the READMEs before the semester starts so that all the dev setup instructions are gtg and work on all platforms @bracyw, for Scylla and the Client, had some small issues with Scylla when testing this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested. 100% works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes
Update client to maintain all old functionality with the new changes to Scylla:
Clean up the DataType enum file, rename it, and move its file to the src/ folder, so it's not hidden away since we use it in basically all of our custom components that aren't the graph page
Also includes an update to Scylla so that the dependencies play nice on Windows (removes ability to connect to the database over TLS from Scylla, but should be no biggy)
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)Closes #260 (issue #)