-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update prettier/linter setup and workflows #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM everything works on my end.
@@ -31,23 +33,33 @@ | |||
"apexcharts": "^3.44.0", | |||
"mapbox-gl": "^3.1.0", | |||
"material-design-icons": "^3.0.1", | |||
"ng-apexcharts": "^1.8.0", | |||
"ng-apexcharts": "1.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no more updates to compatible versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was giving me some annoying dependency errors, removing it was the quickest fix
Changes
Get Prettier and Linters working again
Some info on the linting rules Angular adds in by default: https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/src/configs/README.md
I removed the react linting rules we still had in there from the og creation of the app (lol), and removed the angular accessibility linting rules from our eslintrc.json that angular adds by default (just felt like a bit much). The rest of the rules added by angulareslint recommended seemed pretty reasonable things mostly related to style
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)Closes # (issue #)