Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prettier/linter setup and workflows #257

Merged
merged 15 commits into from
Dec 19, 2024

Conversation

RChandler234
Copy link
Contributor

@RChandler234 RChandler234 commented Dec 15, 2024

Changes

Get Prettier and Linters working again

Some info on the linting rules Angular adds in by default: https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/src/configs/README.md

I removed the react linting rules we still had in there from the og creation of the app (lol), and removed the angular accessibility linting rules from our eslintrc.json that angular adds by default (just felt like a bit much). The rest of the rules added by angulareslint recommended seemed pretty reasonable things mostly related to style

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@RChandler234 RChandler234 self-assigned this Dec 15, 2024
Copy link
Contributor

@bracyw bracyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM everything works on my end.

.github/workflows/lint-check.yml Show resolved Hide resolved
@@ -31,23 +33,33 @@
"apexcharts": "^3.44.0",
"mapbox-gl": "^3.1.0",
"material-design-icons": "^3.0.1",
"ng-apexcharts": "^1.8.0",
"ng-apexcharts": "1.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no more updates to compatible versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was giving me some annoying dependency errors, removing it was the quickest fix

@RChandler234 RChandler234 merged commit 85bee49 into develop Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants