Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#198 Texts Should Not Be Selectable By Default #224

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

JunxiangLin1
Copy link
Contributor

@JunxiangLin1 JunxiangLin1 commented Oct 10, 2024

Changes

Text highlighting has been disabled.

Notes

Text highlighting has been disabled.

Screenshots

image

To Do

Any remaining things that need to get done

none

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #198 (issue #)

@JunxiangLin1 JunxiangLin1 self-assigned this Oct 13, 2024
Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@RChandler234 RChandler234 merged commit d8997f2 into develop Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client] - Texts Should Not Be Selectable By Default
2 participants