Free cluster_async_data in cases where hiredis don't takes ownership
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hiredis API `redisAsyncFormattedCommand()` fail to push a given callback to its internal queue we need to free the cluster_async_data (used as privdata).
zuiderkwast
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hiredis API
redisAsyncFormattedCommand()fail to push a given callback to its internal queue we need to free the memory ofcluster_async_data(which is used asprivdata).Before #225 this could happen when sending a command right after initiating a disconnect, but now its mainly in OOM cases.
Make sure we also keep the error message from
redisAsyncFormattedCommand().Fixes #229