Add non-const connect callback #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `hiredis` >= v1.1.0 is used an alternative connect callback can be
registered using:
int redisClusterAsyncSetConnectCallbackNC(redisClusterAsyncContext *acc,
redisConnectCallbackNC *fn);
The callback function should have following prototype, aliased to redisConnectCallbackNC:
void(redisAsyncContext *ac, int status);
The connect callback will be passed a non-const `redisAsyncContext*` on invocation
which e.g. allows the callback to set a push callback.
The build will check if the used hiredis version supports it,
but the new API can manually be disabled in a build via:
CFLAGS=-DHIRCLUSTER_NO_NONCONST_CONNECT_CB
zuiderkwast
reviewed
Mar 15, 2024
Co-authored-by: Viktor Söderqvist <[email protected]>
zuiderkwast
approved these changes
Mar 15, 2024
zuiderkwast
reviewed
Mar 15, 2024
Co-authored-by: Viktor Söderqvist <[email protected]>
zuiderkwast
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
hiredis>= v1.1.0 is used an alternative connect callback can be registered using:The callback function should have the following prototype, aliased to
redisConnectCallbackNC:void(redisAsyncContext *ac, int status);The connect callback will be passed a non-const
redisAsyncContext*on invocation whiche.g. allows the callback to set a push callback.
The build will check if the used hiredis version supports it, but the new API can also manually be disabled in a build via:
CFLAGS=-DHIRCLUSTER_NO_NONCONST_CONNECT_CBNote: Not available on Windows. The file
hiredis_cluster.defwould need to includeredisClusterAsyncSetConnectCallbackNConly whenhiredis>= v1.1.0 and this requires special handling.