Feat/imei programming #466
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boundlesscalm
commented
Apr 10, 2024
•
boundlesscalm
commented
- Polish UI and spacing
- nRF9151: not needed as slot 1 is pre-written. (maybe give option to write to slot 2?)
- nRF9131: Customer needs to get their own IMEI from GSMA (cannot get from nRF Cloud)
boundlesscalm
added
doc required
greg-fer
reviewed
Apr 10, 2024
boundlesscalm
force-pushed
the
feat/imei-programming
branch
from
fe74780
to
4ef6c09
Compare
kylebonnici
reviewed
Apr 11, 2024
boundlesscalm
force-pushed
the
feat/imei-programming
branch
from
4ef6c09
to
4d36626
Compare
greg-fer
requested changes
Apr 15, 2024
boundlesscalm
force-pushed
the
feat/imei-programming
branch
2 times, most recently
from
76f771b
to
05b938a
Compare
greg-fer
requested changes
Apr 16, 2024
boundlesscalm
force-pushed
the
feat/imei-programming
branch
2 times, most recently
from
4b4df3c
to
50d8639
Compare
greg-fer
approved these changes
Apr 16, 2024
boundlesscalm
force-pushed
the
feat/imei-programming
branch
2 times, most recently
from
3e55af6
to
86395ed
Compare
greg-fer
requested changes
Apr 26, 2024
greg-fer
approved these changes
Apr 26, 2024
|
|
Had inverted expression
boundlesscalm
force-pushed
the
feat/imei-programming
branch
from
8acb2b5
to
c9bfe5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.