Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

AndroidX support and updates #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bazted
Copy link

@bazted bazted commented Dec 11, 2019

Upgrade Android Gradle Plugin to 3.5.3
Upgrade Gradle Wrapper to 6.0.1
Use AndroidX LocalBroadcastManager
Clean repo and improve .gitignore
Added required permission to manifest

@glanderson42
Copy link

Hey! Is scanning worked for you?

@bazted
Copy link
Author

bazted commented Dec 28, 2019

Hey @glanderson42. Yes, scanning worked correctly. Do you have any issues?

@bazted
Copy link
Author

bazted commented Dec 28, 2019

Oh, the code for asking location permission is not in the PR. I will add it and then everything should work fine. Currently, you can allow the location permission in the Applications Settings and scanning will work.

@glanderson42
Copy link

I think I forgot to add it too. I will give it a try tomorrow

@glanderson42
Copy link

I've added

    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

and give permission to the app to access the location but scanning is still not work.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Taras Bazyshyn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants