Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Logging for Debugging in sequence and train Functions #423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhruvErry
Copy link

Description:

This PR addresses Issue #422 by improving the debugging experience for the sequence and train functions. It ensures that critical metadata (machine hostname and full command-line invocation) is logged at the start of the run.

Key Changes:

  1. Added logging for:

    • Machine hostname using socket.gethostname().
    • Full command used to invoke the script (sys.argv).
  2. Placed the new logs immediately after logging setup, ensuring they are captured even if the process fails early.

  3. Applied the changes uniformly across both the sequence and train functions for consistency.

Modified sequence and train functions to log information at start of run.
@bittremieux
Copy link
Collaborator

Hi @dhruvErry, thank you for your contribution.

In this case, we are already logging the machine hostname and the executed command at the end of the program's execution in our development version (dev branch) here.

For your PR to be incorporated, please modify it:

  • Open it against dev instead of main.
  • Refactor the existing log_run_report to be split into information that can be logged at the start of the run and at the end of the run, respectively.
  • Correspondingly modify when these logging functions are called in casanovo.py.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants