Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use geometric mean to calculate peptide score #280

Closed
wants to merge 1 commit into from
Closed

Conversation

bittremieux
Copy link
Collaborator

No description provided.

@bittremieux bittremieux marked this pull request as draft January 20, 2024 19:43
@melihyilmaz
Copy link
Collaborator

I compared arithmetic vs. geometric mean based peptide scores at inference time for both n_beams=1 and n_beams=10 on the mouse dataset from 9-species (where we have the lowest AP for Casanovo). These results are inline with the earlier results: even when we use geometric beam at inference time to select the highest scoring peptide for n_beams=10 we predict the exact same peptide as arithmetic mean ~90% of the time. In the remaining 10% of all spectra where we predict a different peptide with geometric mean, we’re mostly switching from one precursor filter-fitting incorrect peptide to another filter-fitting incorrect peptide for the most part.

@bittremieux bittremieux deleted the pep_score branch February 20, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants