Fix spectra skipping and add min_n_peaks option #265
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips spectra with fewer than min_n_peaks (min_n_peaks=20 by default) and adds the corresponding config option. Fixes #264
This solution is a bit hacky and discards spectra at the batching stage but I think the existing functionality for skipping spectra was buggy to begin with: it only replaces the spectra to be skipped with dummy spectra and runs the model on those dummies so that we still get predictions for them. Am I missing something, @bittremieux @wfondrie?
TODOs: