Skip to content

Commit

Permalink
non zero aa score test case, changelog item
Browse files Browse the repository at this point in the history
  • Loading branch information
Lilferrit committed Oct 15, 2024
1 parent 103c763 commit 83a40c7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- The `--output` option has been split into two options, `--output_dir` and `--output_root`.
- The `--validation_peak_path` is now optional when training; if `--validation_peak_path` is not set then the `train_peak_path` will also be used for validation.
- The `tb_summarywriter` config option is now a boolean config option, and if set to true the TensorBoard summary will be written to a sub-directory of the output directory named `tensorboard`.
- The Casanovo model peptide level score is now reported as the geometric mean of the raw amino acid scores, rather then the arithmetic mean.

### Fixed

Expand Down
5 changes: 5 additions & 0 deletions tests/unit_tests/test_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,11 @@ def test_aa_pep_score():
np.testing.assert_array_equal(aa_scores, np.asarray([0.0, 0.25, 0.5]))
assert peptide_score == pytest.approx(-1.0)

aa_scores_raw = np.asarray([1.0, 0.25])
aa_scores, peptide_score = _aa_pep_score(aa_scores_raw, True)
np.testing.assert_array_equal(aa_scores, np.asarray([0.75, 0.375]))
assert peptide_score == pytest.approx(0.5)


def test_beam_search_decode():
"""
Expand Down

0 comments on commit 83a40c7

Please sign in to comment.