Correctly report AA precision and recall during validation (#253)

Fixes #252. Co-authored-by: Melih Yilmaz <[email protected]>
Noble-Lab · Oct 24, 2023 · 3a18fed · 3a18fed
1 parent 9a44630
commit 3a18fed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -37,6 +37,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Specifying custom residues to retrain Casanovo is now possible.
 - Upgrade to depthcharge v0.2.3 to fix sinusoidal encoding and for the `PeptideTransformerDecoder` hotfix.
 - Enable gradients during prediction and validation to avoid NaNs from occuring as a temporary workaround until a new Pytorch version is available.
+- Correctly report amino acid precision and recall during validation.
 
 ## [3.3.0] - 2023-04-04
 

diff --git a/casanovo/denovo/model.py b/casanovo/denovo/model.py
@@ -766,8 +766,8 @@ def validation_step(
 
         aa_precision, _, pep_precision = evaluate.aa_match_metrics(
             *evaluate.aa_match_batch(
-                peptides_pred,
                 peptides_true,
+                peptides_pred,
                 self.decoder._peptide_mass.masses,
             )
         )