google-chrome: Fix Qt support #375279
Open
google-chrome: Fix Qt support #375279
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a complete beginner at this, but at least I can attest to the changes working on my machine, related to #228751 |
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
aucub
reviewed
Jan 20, 2025
Comment on lines
98
to
99
| qtbase, | ||
| wrapQtAppsHook, |
There was a problem hiding this comment.
Suggested change
| qtbase, | |
| wrapQtAppsHook, | |
| qt6, |
| @@ -162,6 +166,7 @@ let | |||
| ++ [ | |||
| gtk3 | |||
| gtk4 | |||
| qtbase | |||
There was a problem hiding this comment.
Suggested change
| qtbase | |
| qt6.qtbase |
| @@ -180,6 +185,8 @@ let | |||
| nativeBuildInputs = [ | |||
| makeWrapper | |||
| patchelf | |||
| # needed for QT support | |||
| wrapQtAppsHook | |||
There was a problem hiding this comment.
Suggested change
| wrapQtAppsHook | |
| qt6.wrapQtAppsHook |
| @@ -190,6 +197,8 @@ let | |||
| gtk4 | |||
| # needed for GSETTINGS_SCHEMAS_PATH | |||
| gsettings-desktop-schemas | |||
| # needed for QT support | |||
| qtbase | |||
There was a problem hiding this comment.
Suggested change
| qtbase | |
| qt6.qtbase |
| @@ -190,6 +197,8 @@ let | |||
| gtk4 | |||
| # needed for GSETTINGS_SCHEMAS_PATH | |||
| gsettings-desktop-schemas | |||
| # needed for QT support | |||
| qtbase | |||
| ]; | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| dontWrapQtApps=true; |
add $qtWrapperArgs to makeWrapper
Up until now, the AllowQt feature and the "Use Qt" button on Chrome's settings simply did nothing, now, they work. Related to: NixOS#228751
stereomato
force-pushed
the
google-chrome-qt
branch
from
3561b7b to
c5eec81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, up until now Google Chrome simply wasn't capable of using the Qt engine support. Clicking on the "Use Qt" button on Appearance settings would do nothing.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.