Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ytdl-sub: 2024.12.27 -> 2025.01.15 #374171

Merged
merged 2 commits into from
Jan 18, 2025
Merged

ytdl-sub: 2024.12.27 -> 2025.01.15 #374171

merged 2 commits into from
Jan 18, 2025

Conversation

Defelo
Copy link
Member

@Defelo Defelo commented Jan 15, 2025

Changelog: https://github.com/jmbannon/ytdl-sub/releases/tag/2025.01.15

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from LoCrealloc January 15, 2025 23:53
Atemu
Atemu approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM but please split refactors and update into separate commits; one commit per logical step.

@Defelo Defelo added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 17, 2025
FliegendeWurst
FliegendeWurst approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor LGTM.

Update itself is not relevant for us, since we use our own yt-dlp.

@FliegendeWurst FliegendeWurst merged commit 640c0df into NixOS:master Jan 18, 2025
27 of 29 checks passed
@Defelo Defelo deleted the ytdl-sub branch January 18, 2025 14:04
@Atemu
Copy link
Member

Atemu commented Jan 18, 2025

Update itself is not relevant for us, since we use our own yt-dlp.

Are you sure? yt-dlp is not an input to the drv.

@FliegendeWurst
Copy link
Member

There is with python3Packages; [ yt-dlp ]

@Atemu
Copy link
Member

Atemu commented Jan 18, 2025

Ah, I see.

dustypomerleau pushed a commit to dustypomerleau/nixpkgs that referenced this pull request Jan 20, 2025
@FliegendeWurst @dustypomerleau
ytdl-sub: 2024.12.27 -> 2025.01.15 (NixOS#374171)
d68db93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoCrealloc LoCrealloc LoCrealloc approved these changes

@Atemu Atemu Atemu approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Defelo @Atemu @FliegendeWurst @LoCrealloc