nixos/k3s: add autoDeployCharts option and use systemd-tmpfiles for content activation
#374017
+678
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
rorosen
force-pushed
the
k3s-auto-deploy-helm
branch
3 times, most recently
from
9f680c6 to
5ffa146
Compare
| @@ -361,6 +361,8 @@ | |||
| - The paperless module now has an option for regular automatic export of | |||
| documents data using the integrated document exporter. | |||
|
|
|||
| - `services.k3s` now provides the [](#opt-services.k3s.autoDeployCharts) option that allows to automatically deploy Helm charts via the k3s Helm controller. | |||
There was a problem hiding this comment.
Suggested change
| - `services.k3s` now provides the [](#opt-services.k3s.autoDeployCharts) option that allows to automatically deploy Helm charts via the k3s Helm controller. | |
| - `services.k3s` now provides the [](#opt-services.k3s.autoDeployCharts) option that allows to automatically deploy Helm charts via the k3s Helm controller. |
[] is empty. Rendering is:
There was a problem hiding this comment.
Oh true, now that you say it I'm not even sure that this kind of option referencing works outside of option descriptions. I changed it to autoDeployCharts for now.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/declaring-k3s-with-helm-and-cluster/56787/9 |
rorosen
force-pushed
the
k3s-auto-deploy-helm
branch
2 times, most recently
from
5ab580e to
2e1b724
Compare
The `autoDeployCharts` option further improves the auto deploying capabilities of the k3s module by allowing to deploy and configure Helm charts that are then instaled via the k3s Helm controller. Although this was also previously possible by using auto deploying manifests, it required some knowledge of the k3s Helm controller and led to a lot of boilerplate code.
Formerly a `ExecStartPre` script was used to link k3s content. Building the script got fairly messy and it had some footguns like forgetting to create parent directories before linking or silent overriding of existing links.
rorosen
force-pushed
the
k3s-auto-deploy-helm
branch
from
2e1b724 to
52444bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
The
autoDeployChartsoption further improves the auto deployingcapabilities of the k3s module by allowing to deploy and configure Helm charts
that are then instaled via the k3s Helm controller. Although this was
also previously possible by using auto deploying manifests, it required
some knowledge of the k3s Helm controller and led to a lot of
boilerplate code.
In the process I noticed how messy and fragile the
activateK3sContentscript was. Therefore a second commit replaces the script with systemd-tmpfiles.Building the script got fairly messy and it had some footguns like
forgetting to create parent directories before linking or silent
overriding of existing links.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@NixOS/k3s
Add a 👍 reaction to pull requests you find important.