nexus: 3.70.1-02 -> 3.71.0-06 #372472
Closed
nexus: 3.70.1-02 -> 3.71.0-06 #372472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
nix-owners
bot
requested review from
luftmensch-luftmensch,
zaninime,
ironpinguin and
aespinosa
|
Renaming of branch caused recreation of the PR, sorry, see #372484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Following the migration guide between nexus versions 3.69 to 3.71+, requires changing the java version inbetween. You first have to go to 3.70 on java 8, then switch to java 17 and switch the database to a h2 database, then you can upgrade to 3.71+
That's why this non-latest version should be in nixpkgs as well imho.
An even better way would probably be to split up nexus into something like nexus-3-69, nexus-3-70, nexus-3-71 packages or something like that to prevent breaking changes simply by doing a normal update on a stable release. But I am not familiar enough with the best practices in Nixpkgs regarding such changes and would request some help by someone more experienced to not fuck stuff up and break peoples installation without notification.
After 3.71.0-06 it seems as if updates are easy and such complicated migration paths are not necessary anymore.
You can find the nexus docs regarding updates here: https://help.sonatype.com/en/installation-and-upgrades.html
Add a 👍 reaction to pull requests you find important.