libwacom: Fix libwacom-show-stylus #372392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would fail like this: ``` > libwacom-show-stylus Error: No module named 'libevdev' One or more python modules are missing. Please install those modules and re-run this tool. ``` Or even earlier if the system does not have any python3: ``` > sudo libwacom-show-stylus /usr/bin/env: ‘python3’: No such file or directory ``` With this change it can work: ``` > sudo ./result/bin/libwacom-show-stylus Using "ILIT2901:00 222A:0001 Stylus": /dev/input/event7 Using stylus file(s): /nix/store/995gjgcafxbssn50k3bhksws7jnb28cx-libwacom-2.14.0/share/libwacom/lenovo.stylus, /nix/store/995gjgcafxbssn50k3bhksws7jnb28cx-libwacom-2.14.0/share/libwacom/wacom.stylus Tool id 0x0 serial 0xff in-proximity: False ``` Signed-off-by: Daniel Schaefer <[email protected]>
github-actions
bot
added
10.rebuild-darwin: 0
dotlambda
reviewed
Jan 9, 2025
| pp.libevdev | ||
| pp.pyudev | ||
| ])) | ||
|
|
| @@ -37,14 +37,18 @@ stdenv.mkDerivation (finalAttrs: { | |||
| pkg-config | |||
| meson | |||
| ninja | |||
| python3 | |||
There was a problem hiding this comment.
Is it not needed at build time? Does cross compilation still work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would fail like this:
Or even earlier if the system does not have any python3:
With this change it can work:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.