-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sirula: 1.0.0-unstable to 1.1.0 #371977
base: master
Are you sure you want to change the base?
sirula: 1.0.0-unstable to 1.1.0 #371977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of pname binding here is discouraged.
depends on #372016 now for maintainer update |
You can add yourself to maintainers in the same PR, just make sure the commit that touches the maintainers file comes before the commit that changes the package. |
Also, the package isn't formatted properly. Please make sure you are using Here is the diff for reference: -{ nix-update-script, lib, fetchFromGitHub, rustPlatform, pkg-config, gtk3
-, gtk-layer-shell, }:
+{
+ nix-update-script,
+ lib,
+ fetchFromGitHub,
+ rustPlatform,
+ pkg-config,
+ gtk3,
+ gtk-layer-shell,
+}:
rustPlatform.buildRustPackage {
pname = "sirula";
version = "1.1.0";
@@ -13,14 +20,16 @@ rustPlatform.buildRustPackage {
cargoLock = {
lockFile = ./Cargo.lock;
outputHashes = {
- "osstrtools-0.2.2" =
- "sha256-Co4pcikfN4vtIVK7ZsRGCWMAhMJWNNVZe/AdN1nMlmQ=";
+ "osstrtools-0.2.2" = "sha256-Co4pcikfN4vtIVK7ZsRGCWMAhMJWNNVZe/AdN1nMlmQ=";
};
};
nativeBuildInputs = [ pkg-config ];
- buildInputs = [ gtk3 gtk-layer-shell ];
+ buildInputs = [
+ gtk3
+ gtk-layer-shell
+ ];
passthru.updateScript = nix-update-script { }; |
oh well, it's needed across a few PRs for me to become maintainer, better not to pin it to any one of them |
I use it like |
Thats odd, should be the correct usage... |
Ah, ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format this file again.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.