Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 17.6.2 -> 17.7.1 #371838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gitlab: 17.6.2 -> 17.7.1 #371838

wants to merge 1 commit into from
+314 −283

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Jan 7, 2025 •
edited
Loading

https://about.gitlab.com/releases/2024/12/19/gitlab-17-7-released/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Tested on my instance.`

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from talyz, globin, krav and yayayayaka January 7, 2025 16:03
@leona-ya leona-ya requested a review from xanderio January 7, 2025 16:28
@leona-ya leona-ya marked this pull request as ready for review January 7, 2025 16:29
xanderio
xanderio approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@xanderio xanderio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff itself LGTM, let's wait until the nixosTest passes.

@leona-ya leona-ya added the backport release-24.11 Backport PR automatically label Jan 7, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 7, 2025
@leona-ya leona-ya changed the title gitlab: 17.6.2 -> 17.7.0 gitlab: 17.6.2 -> 17.7.1 Jan 8, 2025
@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 8, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xanderio xanderio xanderio approved these changes

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@krav krav Awaiting requested review from krav

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leona-ya @xanderio @wegank