Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] homepage-dashboard: prefix nixpkgs-specific env var with NIXPKGS_ #371559

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Jan 6, 2025

Bot-based backport to release-24.11, triggered by a label in #371244.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

I thought HOMEPAGE_CACHE_DIR was an upstream env var, and it confused me
a lot. Let's prefix it with NIXPKGS_ to make it clear that it's nixpkgs
specific.

(cherry picked from commit be0fda6)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 6, 2025
@bjornfor
Copy link
Contributor

bjornfor commented Jan 6, 2025

This is a dependency of #371531.

@bjornfor bjornfor merged commit 6f17a8c into release-24.11 Jan 6, 2025
28 of 32 checks passed
@bjornfor bjornfor deleted the backport-371244-to-release-24.11 branch January 6, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant