inori: init at 0.2.1 #371494
Closed
inori: init at 0.2.1 #371494
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelroses
reviewed
Jan 6, 2025
|
Defelo
reviewed
Jan 6, 2025
|
getchoo
reviewed
Jan 6, 2025
inori: init at 0.2.1 apply suggestions
getchoo
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM. Feel free to ping me in a couple days if there are no other reviews :)
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 371494
aarch64-linux
✅ 1 package built:
- inori
getchoo
added
the
12.approvals: 1
|
Note: There is another PR #371762 which has the upstream developer in it. |
noted, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/eshrh/inori/blob/master/README.md
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.