Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowfi: init at 1.5.3 #371342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lowfi: init at 1.5.3 #371342

wants to merge 2 commits into from

Conversation

ZarredFelicite
Copy link

Adds lowfi, an extremely simple lofi player.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ddogfoodd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371342


x86_64-linux

✅ 1 package built:
  • lowfi

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 6, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
pkgs/by-name/lo/lowfi/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/lowfi/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/lowfi/package.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 7, 2025
@ddogfoodd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371342


x86_64-linux

✅ 1 package built:
  • lowfi

@Defelo
Copy link
Member

Defelo commented Jan 7, 2025

@ZarredFelicite Please rebase your branch to contain only the two commits maintainers: add zsenai and lowfi: init at 1.5.3 (see contributing guide)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants