Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11]: nixos/jupyter: migrate service to jupyter 7 setup #371199

Merged
merged 1 commit into from
Jan 5, 2025
Merged

[Backport release-24.11]: nixos/jupyter: migrate service to jupyter 7 setup #371199

merged 1 commit into from
Jan 5, 2025

Conversation

JohnRTitor
Copy link
Contributor

Followup of #367106

@b-m-f @JohnRTitor
nixos/jupyter: migrate service to jupyter 7 setup (NixOS#367106)
d9b0624 
Signed-off-by: Maximilian Ehlers <[email protected]>
Signed-off-by: John Titor <[email protected]>
(partially cherry picked from commit f199d57)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 5, 2025
GaetanLepage
GaetanLepage approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@JohnRTitor
Copy link
Contributor Author

Cherry-pick check failure is expected as we had to remove 25.05 release notes change for this branch.

@JohnRTitor JohnRTitor merged commit f71f6c6 into NixOS:release-24.11 Jan 5, 2025
19 of 24 checks passed
@JohnRTitor JohnRTitor deleted the backport-jupyter-fix branch January 5, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnRTitor @GaetanLepage @b-m-f