-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging-next-24.11] Node.js backports #371149
Conversation
this test is failing on both armv7 and i686 and is related to year 2038 issue so it probably affects all 32 bit platforms (cherry picked from commit 815ec0c)
(cherry picked from commit 1e99bca)
(cherry picked from commit 94d2817)
(cherry picked from commit 5cb1de1)
(cherry picked from commit f634fa2)
Same as NixOS#356257 (cherry picked from commit cb05815)
(cherry picked from commit bc35348)
(cherry picked from commit e4f4440)
(cherry picked from commit 2b8df76)
LGTM, although I suppose nodejs_22 will need the same libuv-related reverts as Node.js 23.x |
Ah, I foolishly only tested v20 to speed the process of unblocking (We could potentially just upgrade |
If that helps, I've opened #371201
I didn't follow that closely but I don't think it created any breakage when it was updated on |
Those just look like regular ofborg transient failures and timeouts rather than anything too concerning. Sorry for missing that PR; it should be fine to throw the SQLite changes and |
This brings the
staging-next-24.11
Node.js derivation up to date withstaging
, apart from:libuv
on that branch.I’m hoping this will fix #369690 (comment), but I still need to build it. It will be a fair few rebuilds to eat, of course; the alternative would be guessing at which parts of these make the difference and conditionalizing them on
x86_64-darwin
. Not sure that’s worth it.I’m also not really sure what the cause of all this is; the only real changes to the Node derivation from
release-24.11
tostaging-next-24.11
are Python andlibxml2
bumps, but the Python bump is onmaster
as well. My hope is that it’s LLVM or something. My fear is that maybe we’re exposing somelibuv
issue that the bump onmaster
hid. I dunno.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.