Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next-24.11] Node.js backports #371149

Merged
merged 10 commits into from
Jan 5, 2025

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jan 5, 2025

This brings the staging-next-24.11 Node.js derivation up to date with staging, apart from:

I’m hoping this will fix #369690 (comment), but I still need to build it. It will be a fair few rebuilds to eat, of course; the alternative would be guessing at which parts of these make the difference and conditionalizing them on x86_64-darwin. Not sure that’s worth it.

I’m also not really sure what the cause of all this is; the only real changes to the Node derivation from release-24.11 to staging-next-24.11 are Python and libxml2 bumps, but the Python bump is on master as well. My hope is that it’s LLVM or something. My fear is that maybe we’re exposing some libuv issue that the bump on master hid. I dunno.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

symphorien and others added 10 commits January 5, 2025 14:47
this test is failing on both armv7 and i686 and is related to year 2038
issue so it probably affects all 32 bit platforms

(cherry picked from commit 815ec0c)
(cherry picked from commit 1e99bca)
libc++ 19 no longer supports Clang < 17.

This reverts commit b034e4c.

(cherry picked from commit 42ef358)
(cherry picked from commit f634fa2)
Same as NixOS#356257

(cherry picked from commit cb05815)
(cherry picked from commit bc35348)
@emilazy emilazy requested review from vcunat and aduh95 January 5, 2025 15:21
@emilazy emilazy merged commit ea2f362 into NixOS:staging-next-24.11 Jan 5, 2025
23 of 28 checks passed
@emilazy emilazy deleted the push-sumqsuvtzolx branch January 5, 2025 16:34
@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2025

LGTM, although I suppose nodejs_22 will need the same libuv-related reverts as Node.js 23.x

@emilazy
Copy link
Member Author

emilazy commented Jan 5, 2025

Ah, I foolishly only tested v20 to speed the process of unblocking staging-next-24.11 up. Will check the other versions too and patch as appropriate.

(We could potentially just upgrade libuv next cycle on 24.11, I don’t know if it’s breaking or not?)

@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2025

If that helps, I've opened #371201

(We could potentially just upgrade libuv next cycle on 24.11, I don’t know if it’s breaking or not?)

I didn't follow that closely but I don't think it created any breakage when it was updated on master/staging, so I'd expect it to not be too breaking – I tried to do that in #368368 but didn't find the time to investigate the ofborg failures

@emilazy
Copy link
Member Author

emilazy commented Jan 5, 2025

Those just look like regular ofborg transient failures and timeouts rather than anything too concerning. Sorry for missing that PR; it should be fine to throw the SQLite changes and libuv bump in the next staging-24.11, if you wanted to rebase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants